[tune] add mode/metric parameters to tune.run#10627
Merged
richardliaw merged 13 commits intoray-project:masterfrom Sep 9, 2020
Merged
[tune] add mode/metric parameters to tune.run#10627richardliaw merged 13 commits intoray-project:masterfrom
richardliaw merged 13 commits intoray-project:masterfrom
Conversation
added 5 commits
September 7, 2020 19:06
# Conflicts: # python/ray/tune/suggest/bohb.py # python/ray/tune/suggest/dragonfly.py # python/ray/tune/suggest/nevergrad.py # python/ray/tune/suggest/skopt.py # python/ray/tune/suggest/zoopt.py
richardliaw
approved these changes
Sep 8, 2020
Contributor
richardliaw
left a comment
There was a problem hiding this comment.
looks good, straightforward
6 tasks
Member
|
we should also update the |
Contributor
Author
|
Absolutely. Updated the PR. Thanks for spotting this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See title. Also removes default RLLib parameter values for searchers/schedulers.
Needs full testing suite to run and maybe some example and an end-to-end test.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.